Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge mark positions incorrect #3407

Open
miloush opened this issue Jan 7, 2024 · 7 comments
Open

merge mark positions incorrect #3407

miloush opened this issue Jan 7, 2024 · 7 comments

Comments

@miloush
Copy link
Contributor

miloush commented Jan 7, 2024

Merging Noto Sans Tamil Supplement, Noto Sans Tangsa and Noto Sans results in some of the combining diacritics broken:

Expected vs Actual:
image

It does not reproduce when merging one or other with Noto Sans, it has to be all three.
It does not reproduce when Tangsa is first and Tamil Supplement is second.

pyftmerge NotoSansTamilSupplement\googlefonts\ttf\NotoSansTamilSupplement-Regular.ttf  NotoSansTangsa\googlefonts\ttf\NotoSansTangsa-Regular.ttf NotoSans\googlefonts\ttf\NotoSans-Regular.ttf

Rendered string: r̥l̥ (r and l with ring below)

@behdad
Copy link
Member

behdad commented Jan 7, 2024

Unfortunately the merger is unmaintained and very limited. I don't think I'll have the time to look into this :(.

@miloush
Copy link
Contributor Author

miloush commented Jan 7, 2024

No worries. Can you tell me a bit about OTLOffsetOverflowError, how is it being fixed?

@behdad
Copy link
Member

behdad commented Jan 7, 2024

Can you tell me a bit about OTLOffsetOverflowError, how is it being fixed?

That is automatically taken care of by the compiler, by using Extension lookups, or splitting subtables into smaller ones. That shouldn't be your problem if the merge succeeds.

@behdad
Copy link
Member

behdad commented Jan 7, 2024

There's some mark-attachment-related issues with merger. I think you might be hitting that.

#3407

@miloush
Copy link
Contributor Author

miloush commented Jan 10, 2024

My obervations so far: The Tangsa And Tamil Supplement have the same anchor points:

image

The Noto Sans has two extra:

image

It is unclear to me why the order of the first two matters yet. The merged font has only the points in the first image. The bottom attachment point is first in all cases.

@miloush
Copy link
Contributor Author

miloush commented Jan 10, 2024

To clarify, all 3 fonts have a glyph for r. Given that I tried to merge two fonts with identical glyphs 0-9 only and they were both included in the new font, i.e. not deduplicated, I suspect the mark issue is a consequence of this - the features simply not applying to the glyphs that won cmap.

@behdad
Copy link
Member

behdad commented Jan 10, 2024

Sounds like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants