Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[t1Lib] Fix several Type 1 issues #3240

Merged
merged 2 commits into from Aug 4, 2023
Merged

[t1Lib] Fix several Type 1 issues #3240

merged 2 commits into from Aug 4, 2023

Conversation

justvanrossum
Copy link
Collaborator

@justvanrossum justvanrossum commented Aug 3, 2023 •
edited

Fix several issues exposed by the fonts posted in #3238. This fixes #3238.

  • fix when /Private follows /CharStrings instead of vice versa as is more common
  • fix expected ND and PD values
  • handle the case where lenIV is not 4 (writing)
  • write /Subrs properly, not just the "standard 5"

@justvanrossum
Fix several issues exposed by the fonts posted in #3238
2808d99 
- fix when /Private follows /CharStrings instead of vv
- fix expected ND and PD values
- handle the case where lenIV is not 4 (writing)
- write /Subrs properly, not just the "standard 5"
@justvanrossum justvanrossum mentioned this pull request Aug 3, 2023
Open
@justvanrossum justvanrossum merged commit 7d6d057 into main Aug 4, 2023
10 checks passed
@justvanrossum justvanrossum deleted the issue3238 branch August 4, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[T1Lib] T1Font.saveAs() broken?
2 participants
@justvanrossum @anthrotype