Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cffLib.specializer] Fix generalizer blend #2750

Merged
merged 1 commit into from
Aug 17, 2022
Merged

[cffLib.specializer] Fix generalizer blend #2750

merged 1 commit into from
Aug 17, 2022
+28 −10

Conversation

behdad
Copy link
Member

@behdad behdad commented Aug 16, 2022

Fixes #1975

@behdad behdad requested a review from anthrotype August 16, 2022 21:30
@behdad
Copy link
Member Author

behdad commented Aug 16, 2022

@anthrotype Please test. My confidence in this is rather low :(.

@behdad
Copy link
Member Author

behdad commented Aug 16, 2022

@anthrotype Please test. My confidence in this is rather low :(.

I can confirm this fixes your test case.

@behdad
Copy link
Member Author

behdad commented Aug 16, 2022

Ugh. Now varLib CFF2 tests are failing. Looking into it.

@behdad behdad force-pushed the generalizer-fix branch 3 times, most recently from 3ca8840 to 58bba97 Compare August 16, 2022 22:24
@behdad
Copy link
Member Author

behdad commented Aug 16, 2022

Okay, I think this is ready. My confidence is high now, after having fixed the tests.

anthrotype
anthrotype reviewed Aug 17, 2022
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely forgot the details of this one, sorry. If you're confidence is high, I confide in you :)

@behdad behdad merged commit 61160fe into main Aug 17, 2022
@khaledhosny khaledhosny deleted the generalizer-fix branch August 24, 2022 20:28
@fonttools fonttools deleted a comment from behdad Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cffLib.specializer] generalizeProgram returns invalid charstring program?
2 participants
@behdad @anthrotype