Speculatively promote lookups to extension #2465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been looking at overflow resolution this morning, as it is currently the bane of my life. My font takes around 5 minutes to build, most of which time is taken up with resolving lookup overflows. (Not subtable overflows - lookup overflows.) The reason overflow resolution takes so long is that once an overflow is resolved, fontTools goes back and starts the whole compilation process all over again.
Now. It seems to me that if the offset to lookup N is too big to fit in a ushort, the offset to lookup N+1 is going to be too big as well. In fact, all lookups from lookup N onwards are going to need handling. So rather than handling them one at a time, why not just promote the lot to extension lookups?
Doing this takes my font's build time down to 30 seconds, almost none of which is to do with overflow resolution.