Traverse when there is no layer list #2441
Conversation
| def parseXmlInto(font, parseInto, xmlSnippet): | ||
| parsed_xml = [e for e in parseXML(xmlSnippet.strip()) if not isinstance(e, str)] | ||
| for name, attrs, content in parsed_xml: | ||
| parseInto.fromXML(name, attrs, content, font) |
There was a problem hiding this comment.
We use four space indentation
| @@ -687,6 +687,33 @@ def test_splitMarkBasePos(): | |||
| ] | |||
|
|
|||
|
|
|||
| class ColrV1Test(unittest.TestCase): | |||
| def setUp(self): | |||
| self.font = FakeFont(['.notdef', 'meh']) | |||
There was a problem hiding this comment.
Four space indentation please
|
@rsheeter merged. I am going to the fix indentation issue |
| <BaseGlyphPaintRecord index="0"> | ||
| <BaseGlyph value="meh"/> | ||
| <Paint Format="1"><!-- PaintColrLayers --> | ||
| <NumLayers value="0"/> |
There was a problem hiding this comment.
@khaledhosny @rsheeter hm, a NumLayers=0 is very odd, as the whole PaintColrLayers is no-op basically. Did nanoemoji produce that? Maybe the input SVG was completely empty (e.g. a whitespace glyph). I think in this case, we don't want to emit anything, i.e. the BaseGlyphPaintRecord.Paint should be None, not a no-op PaintColrLayers with NumLayers=0.
There was a problem hiding this comment.
Yes, that indeed the case. The glyph in question is space glyph and the SVG produced by picosvg is:
<svg xmlns="http://www.w3.org/2000/svg" version="1.1" viewBox="0 0 130.0 1500.0" width="130.0" height="1500.0">
<defs/>
</svg>
|
Interesting; we should probably file a bug for that in nanoemoji as well. Still good we don't crash here. |
|
@rsheeter I'm already working on a PR (found another bug while working on it 😅) |
…ms (fonttools/fonttools#2441)" This reverts commit 4f5b715. Problem believed fixed by fonttools/fonttools#2441.
Fixes #2438. Again :D In addition to unit test
pyftsubset --output-file=/tmp/reem.ttf --gids=0,128,210,211,218,225,227,232,234,235,237,238,241,244,246,250,251,254,261,264,270,271,277,280,282,284,286,289,295,297,299,307,308,316,317,318,320,327,331,343,345,347,348,349,350,351,357,365,370,371,374,376,378,392,393,398,399 ReemKufiInk-Regular.otfnow doesn't kerplode.