Use a set for file names for clash checking #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
reviewed
Oct 7, 2021
anthrotype
reviewed
Oct 7, 2021
anthrotype
reviewed
Oct 7, 2021
anthrotype
reviewed
Oct 7, 2021
| @@ -455,12 +457,10 @@ def writeGlyph(self, glyphName, glyphObject=None, drawPointsFunc=None, formatVer | |||
| fileName = self.contents.get(glyphName) | |||
| if fileName is None: | |||
| if self._existingFileNames is None: | |||
| self._existingFileNames = {} | |||
| for fileName in self.contents.values(): | |||
| self._existingFileNames[fileName] = fileName.lower() | |||
There was a problem hiding this comment.
I wonder why this self._existingFileNames was a dict to begin with, if we were only using the .values().
I hope nobody else ever accessed that (well, it is prefixed with underscore so technically it's private)
anthrotype
reviewed
Oct 7, 2021
madig
force-pushed
the
ufolib-speed-up-filename-clash-checking
branch
from
e2b788c
to
cd32e1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2421.
Thanks @justvanrossum, right on the money :) In the mentioned script, runtime spent in
glyphNameToFileNamedropped from 20% to 0.15%, that's a 2 minutes reduction on my machine :)I smuggled a type annotation in and directed Python to postpone evaluation of annotations, to avoid the parsing overhead and also because the
set[str] | Nonesyntax is Python 3.9+.