Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check for article visual content #4653

Closed
davelab6 opened this issue Apr 17, 2024 · 0 comments
Closed

Add check for article visual content #4653

davelab6 opened this issue Apr 17, 2024 · 0 comments
Assignees
@felipesanches
Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Milestone
0.12.7

Comments

@davelab6
Copy link
Contributor

Following #4594 I propose a WARN check that (new) families have an ARTICLE page, have a certain minimum lenght (say 100 words or 500 characters), and have at least 1 visual asset embedded in the HTML (and the file(s) are actually present in the repo); the warning message should prompt the user (to prompt the author of the About page, if different) to include an ARTICLE of the required length or more and at least 1 image, preferably an SVG, but can be SVG, PNG, JPEG, MP4 or YouTube link.
@davelab6 davelab6 added this to the 0.12.x milestone Apr 17, 2024
@felipesanches felipesanches added New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id and removed Check improvement proposal labels Apr 18, 2024
@felipesanches felipesanches modified the milestones: 0.12.x, 0.12.7 May 31, 2024
felipesanches added a commit to felipesanches/fontbakery that referenced this issue May 31, 2024
@felipesanches
update check/article/images
b1a59e1 
Ensure article page has minimum length and includes visual assets.
Also added more thorough code-testing.

com.google.fonts/check/article/images
On the Google Fonts profile.

(issue fonttools#4653)
@felipesanches felipesanches mentioned this issue May 31, 2024
Merged
felipesanches added a commit that referenced this issue May 31, 2024
@felipesanches
update check/article/images
acacf4b 
Ensure article page has minimum length and includes visual assets.
Also added more thorough code-testing.

com.google.fonts/check/article/images
On the Google Fonts profile.

(issue #4653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
New check proposal We expect new check proposals to include a detailed rationale description and a suggested check-id
Projects
None yet
Milestone
0.12.7
Development

No branches or pull requests
2 participants
@felipesanches @davelab6