Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation not up to date for angular 17 #933

Open
Jakersnell opened this issue Feb 2, 2024 · 1 comment
Open

Documentation not up to date for angular 17 #933

Jakersnell opened this issue Feb 2, 2024 · 1 comment
Labels
contributors welcome! Open to outside contributors documentation Improvements or additions to documentation

Comments

@Jakersnell
Copy link

Describe the bug

The documentation on installing for angular here is not up to date for angular 17 and will not work.

Steps to Reproduce

Error can be reproduced by attempting to install a font for a project started with Angular CLI: 17.1.2.

Expected behavior

The css file will not be found and the path will not be accepted.

Version

17.1.2

OS

mac os

Browser

google chrome

Additional context

No response

@Jakersnell Jakersnell added the bug Something isn't working label Feb 2, 2024
@jwr1
Copy link
Member

jwr1 commented Feb 2, 2024

Thanks for reporting the issue. I haven't used angular before, so I'm not sure what the problem is. I did briefly look at angular documentation and version 17 changelog for hints, but I didn't see anything. If you (or anyone else) figures out a fix, feel free to make a pr for the angular documentation here.

If I had to guess, I'd say it's that the CSS imports are using a ~ to access (like @import "~@fontsource-variable/open-sans/wght.css";. Maybe you could try using a relative import through node_modules (it's not ideal though) like the following: @import "../node_modules/@fontsource-variable/open-sans/wght.css"; (the exact path might need adjustment).

@ayuhito ayuhito added documentation Improvements or additions to documentation contributors welcome! Open to outside contributors and removed bug Something isn't working labels Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributors welcome! Open to outside contributors documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants