Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@fontsource/material-icons miss some unicode characters support #929

Open
Michsior14 opened this issue Jan 11, 2024 · 4 comments
Open

@fontsource/material-icons miss some unicode characters support #929

Michsior14 opened this issue Jan 11, 2024 · 4 comments
Labels
bug Something isn't working sass Sass related issue

Comments

@Michsior14
Copy link

Describe the bug

In the latest version of @fontsource/material-icons (5.0.11) defaults for $unicode changed leading to problems with support of some code points. eg. e876 or e14c.

e876 in 5.0.11
image

e876 in 5.0.7
image

Steps to Reproduce

  1. use <i class="material-icons">&#xE876;</i> somewhere and no icon will be displayed

Expected behavior

All code points are supported.

Version

5.0.11

OS

Linux

Browser

Chrome, Firefox

Additional context

No response

@Michsior14 Michsior14 added the bug Something isn't working label Jan 11, 2024
@ayuhito
Copy link
Member

ayuhito commented Apr 11, 2024

@Michsior14, can you confirm this is no longer an issue? This may be related to #948.

@Michsior14
Copy link
Author

It's still a problem on the latest version. Just FYI, I am using this workaround since I've reported this issue:

@use 'sass:map';
@use 'sass:meta';

@use '@fontsource/material-icons/scss/mixins' as material;
@use '@fontsource/material-icons/scss/metadata' as materialMetadata;

@include material.faces(
  // Override the unicode range to include all characters
  $metadata:
    map.merge(
      meta.module-variables(materialMetadata),
      (
        unicode: (
          latin: null,
        ),
      )
    ),
);

@ayuhito ayuhito added the sass Sass related issue label Apr 12, 2024
@ayuhito
Copy link
Member

ayuhito commented Apr 22, 2024

Closed in #961.

@ayuhito ayuhito closed this as completed Apr 22, 2024
@Michsior14
Copy link
Author

Unfortunately the issue still persist on the latest.

@ayuhito ayuhito reopened this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sass Sass related issue
Projects
None yet
Development

No branches or pull requests

2 participants