Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libre Baskerville font missing the italic variant #923

Closed
wonrax opened this issue Dec 23, 2023 · 5 comments · Fixed by #927
Closed

Libre Baskerville font missing the italic variant #923

wonrax opened this issue Dec 23, 2023 · 5 comments · Fixed by #927
Labels
bug Something isn't working website Related to website

Comments

@wonrax
Copy link

wonrax commented Dec 23, 2023

Describe the feature you'd like to request

The Libre Baskerville font on Fontsource currently doesn't contain the italic variant, which is different than the normal variant with italic font style. For reference, this font on Google Fonts features 3 styles - Regular, Regular Italic and Bold.

References:
https://github.com/impallari/Libre-Baskerville
https://fonts.google.com/specimen/Libre+Baskerville

Describe the solution you'd like

Add the italic variant.

Describe alternatives you've considered

No response

Additional context

No response

@wonrax wonrax added the enhancement New feature or request label Dec 23, 2023
@wonrax
Copy link
Author

wonrax commented Dec 23, 2023

I just went to look for other fonts and discovered that actually all of them don't have any italic version while the ones on Google Fonts do. This seems to be a larger problem than a single font's mistake.

This is the Playfair Display font with the Regular Italic variant on Google Fonts:
image

And this is the Playfair Display Regular on Fontsource with italic style enabled:
image

I don't know why the Fontsource's font curator made the decision to exclude the italic variants when generating and bundling fonts, but for people that use the italic variant for display, this really matters. If you slap a font-style: italic on a regular variant, it doesn't look the same as using the italic variant.

@ayuhito ayuhito added bug Something isn't working website Related to website and removed enhancement New feature or request labels Dec 23, 2023
@ayuhito
Copy link
Member

ayuhito commented Dec 23, 2023

Good catch! This is a bug with the website rather than the actual files itself. We weren't updating the CSS to point to the italic variants when switching the style. I'll look into it.

@ayuhito
Copy link
Member

ayuhito commented Dec 24, 2023

This should be fixed with #927. However, just noting that you will notice Libre Baskerville 700 Italic won't load, which is a separate bug tracked in #855 where some fonts support 400, 400i, 700 but not 700i.

@wonrax
Copy link
Author

wonrax commented Dec 25, 2023

Thanks for your work. I think this is why Google Fonts displays all the variants on the same page instead of organizing into categories (i.e. normal and italic).

@ayuhito
Copy link
Member

ayuhito commented Dec 25, 2023

Yup, the issue stems deeper for us since our original API implementation didn't consider this to be a possibility, so it's a little difficult to workaround with since our website relies on said API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working website Related to website
Projects
None yet
2 participants