Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild all non-Google fonts to follow v3 format #92

Closed
ayuhito opened this issue Nov 19, 2020 · 2 comments
Closed

Rebuild all non-Google fonts to follow v3 format #92

ayuhito opened this issue Nov 19, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request not stale

Comments

@ayuhito
Copy link
Member

ayuhito commented Nov 19, 2020

Problem

When 3.0.x was released, there were breaking changes that changed how we imported fonts, from fontsource-<package>/<subset>-<weight>-<style>.css to fontsource-<package>/<weight>-<style>.css since it was no longer necessary to specify subsets with the new unicode-range feature.

Unfortunately, the non-Google fonts that were manually added did not follow through with the update and still follows the old subset import method, primarily because they do not have any unicode-range data for us to use.

This has led to confusion from the lack of consistency to cause situations such as #91.

Solution

To resolve this, all these fonts should be repackaged with the default subset used when there isn't any subset specified in the import, irrespective of whether it has unicode-range data or not. That will need changes made to the generic packager and rebuild scripts.

@stale
Copy link

stale bot commented Dec 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
Use the 'not stale' label to prevent the issue from automatically closing.

@stale stale bot added the stale label Dec 19, 2020
@ayuhito ayuhito added not stale and removed stale labels Dec 19, 2020
This was referenced Dec 20, 2020
@ayuhito ayuhito self-assigned this Dec 22, 2020
@ayuhito
Copy link
Member Author

ayuhito commented Dec 24, 2020

Included in the Fontsource v4 release.

@ayuhito ayuhito closed this as completed Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request not stale
Projects
None yet
Development

No branches or pull requests

1 participant