Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop generating 'normal' CSS files #88

Closed
ayuhito opened this issue Nov 18, 2020 · 2 comments
Closed

Stop generating 'normal' CSS files #88

ayuhito opened this issue Nov 18, 2020 · 2 comments
Assignees
Labels
breaking change Issue contains breaking changes enhancement New feature or request not stale

Comments

@ayuhito
Copy link
Member

ayuhito commented Nov 18, 2020

Specification

As an attempt to reduce unnecessary file generation and clutter, as well as follow closer to the import style of Google's Font API, I'm suggesting to completely remove all -normal files in favour of solely keeping them in weight-specific files. The current behaviour for -italic files will remain.

Current:

import fontsource-roboto/400.css // Contains normal AND italics
import fontsource-roboto/400-normal.css // Only normal style
import fontsource-roboto/400-italic.css  // Only italic style

New:

import fontsource-roboto/400.css // Contains only normal style
import fontsource-roboto/400-normal.css // No longer exists
import fontsource-roboto/400-italic.css // Only italic style

Reason

Since the italics style is a very niche selection, it doesn't make sense for it to be included in the default main imports unless specified. Removing the need for specific files for normal style will reduce the file count by a huge margin, reducing the complexity of each package.

For example, Noto Sans JP has 39 CSS files, of which 18 of them are -normal files.

I'd want to implement this breaking change when we have other more impactful breaking changes that we could possibly add. This is just an idea for the future.

@ayuhito ayuhito added enhancement New feature or request breaking change Issue contains breaking changes labels Nov 18, 2020
@stale
Copy link

stale bot commented Dec 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
Use the 'not stale' label to prevent the issue from automatically closing.

@stale stale bot added the stale label Dec 18, 2020
@ayuhito ayuhito added not stale and removed stale labels Dec 18, 2020
@ayuhito ayuhito self-assigned this Dec 22, 2020
@ayuhito
Copy link
Member Author

ayuhito commented Dec 24, 2020

Included in the Fontsource v4 release.

@ayuhito ayuhito closed this as completed Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Issue contains breaking changes enhancement New feature or request not stale
Projects
None yet
Development

No branches or pull requests

1 participant