Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poppins truetype font file can't work with font-feature-settings #771

Closed
catiex opened this issue Jun 30, 2023 · 4 comments
Closed

Poppins truetype font file can't work with font-feature-settings #771

catiex opened this issue Jun 30, 2023 · 4 comments
Labels
api API related issues bug Something isn't working

Comments

@catiex
Copy link

catiex commented Jun 30, 2023

Describe the bug

Fontsource poppins truetype font file can't work with font-feature-settings as Google font.

Steps to Reproduce

  1. Download Poppins font from fontsource
  2. Unzip the above font file and install poppins-latin-400-normal.ttf from poppins/ttf
  3. Open any small projects showing lower case a and use Poppins from locally-installed font.
  4. Enable font-feature-settings: "ss02"; for Poppins font-weight 400.
  5. Verify lower case a not being updated to double storey.
Screenshot 2023-06-30 at 1 28 23 PM

Expected behavior

After enabling (font-feature-settings: "ss02";) for double-storey lower case a with manually installed Google Poppins truetype font file, lower case a shows correctly.

Screenshot 2023-06-30 at 1 39 16 PM

Version

No response

OS

No response

Browser

No response

Additional context

No response

@catiex catiex added the bug Something isn't working label Jun 30, 2023
@ayuhito ayuhito added the api API related issues label Jul 19, 2023
@ayuhito
Copy link
Member

ayuhito commented Jul 19, 2023

We actually convert the woff2 variant of the Google source to ttf which doesn't contain any font-feature-settings options. Ideally we should use the original ttf files provided by Google and the fallback to the conversion method when dealing with non-Google fonts.

Although if the ttf variants don't support font-feature-settings since Google may have stripped those out for size optimisations, supporting this feature would be out of scope.

@catiex
Copy link
Author

catiex commented Jul 20, 2023

We actually convert the woff2 variant of the Google source to ttf which doesn't contain any font-feature-settings options. Ideally we should use the original ttf files provided by Google and the fallback to the conversion method when dealing with non-Google fonts.

Although if the ttf variants don't support font-feature-settings since Google may have stripped those out for size optimisations, supporting this feature would be out of scope.

Hey Ayu, thank you for your reply. I understand Google fonts CDN doesn't support truetype font files from their API for size optimizations, I am not sure if fontsource is considering the same in the future?

@ayuhito
Copy link
Member

ayuhito commented Sep 27, 2023

Hey Ayu, thank you for your reply. I understand Google fonts CDN doesn't support truetype font files from their API for size optimizations, I am not sure if fontsource is considering the same in the future?

This isn't in this project's scope since we only aim to replicate Google Fonts with optimised fonts for the web. It would be too labour-intensive for us to manually support fonts compared to simply mirroring Google Fonts.

If you need explicit support for this, we can only recommend you download from the source itself. Thanks!

@ayuhito ayuhito closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2023
@ayuhito
Copy link
Member

ayuhito commented Sep 29, 2023

After a little bit more thought on this, it might make sense to expand the scope of the project to include this. #39 would be the relevant issue to discuss this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API related issues bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants