Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Montserrat tabular figures not working #59

Closed
marceloverdijk opened this issue Aug 28, 2020 · 2 comments
Closed

Montserrat tabular figures not working #59

marceloverdijk opened this issue Aug 28, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@marceloverdijk
Copy link

Describe the bug
I'm trying to use Montserrat with tabular figures (font-variant-numeric: tabular-nums) but it does not seem to work.
According to JulietaUla/Montserrat#101 this should be supported in the Montserrat font.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://jsfiddle.net/marceloverdijk/mvwg8Lnj/
  2. Click on Run

Expected behavior
Second table should have tabular nums (so every num uses the same width) but does not have it.

Screenshots
image

Additional context
I also used my local installed Montserrat font in the @fontface definition like:

  src:
    local('Montserrat Regular '),
    local('Montserrat-Regular'),

and it that case it does work.

image

Not sure if this is a bug for fontsource.
What source is fontsource using for this font? I understand e.g. Google Font also does not support the tabular figures.

@marceloverdijk marceloverdijk added the bug Something isn't working label Aug 28, 2020
@ayuhito
Copy link
Member

ayuhito commented Aug 29, 2020

@marceloverdijk, I think a similar issue was discussed in #39. We pull our fonts directly from Google and use their stripped out version to cut down on file sizes, which works for the majority of developers utilising Fontsource.

Do you disagree with the explanations in #39 or do you have a solution for the issues stated?

@marceloverdijk
Copy link
Author

Thx this explains it. I prob will end up copying the source files to my project and not using NPM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants