Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose previous response headers to beforeRedirect callback #138

Open
aivils opened this issue Aug 5, 2020 · 3 comments
Open

Expose previous response headers to beforeRedirect callback #138

aivils opened this issue Aug 5, 2020 · 3 comments

Comments

@aivils
Copy link

aivils commented Aug 5, 2020

Of course, the set-cookie should not be considered for this implementation. This implementation must allow the use of set-cookie header.
Current beforeRedirect implementation is too restrictive.
https://github.com/follow-redirects/follow-redirects/blob/master/index.js#L356
It does not allow to access headers of response in the beforeRedirect function.

@intervalia

This comment has been minimized.

@RubenVerborgh

This comment has been minimized.

@RubenVerborgh
Copy link
Collaborator

Ah wait, I got confused by the title and the last comment, but the original issue makes a valid point. Let me restore.

@RubenVerborgh RubenVerborgh reopened this Oct 14, 2020
@RubenVerborgh RubenVerborgh changed the title The set-cookie header at the redirect step is ignored Expose previous response headers to beforeRedirect callback Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants