From 61d843b439f805c92c66d4cd6a23d92fad4ed9fe Mon Sep 17 00:00:00 2001 From: Zak Burke Date: Mon, 10 Oct 2022 09:24:08 -0400 Subject: [PATCH 1/2] FOLIO-3610 provide @babel/core, @babel/preset-env dev-deps MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is a bit of a shot in the dark to resolve build failures in CI like the following: ``` [1mERROR in ./node_modules/@folio/finance/src/common/utils/validateDuplicateFieldValue.js Module build failed (from ./node_modules/babel-loader/lib/index.js): TypeError: /home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@folio/finance/src/common/utils/validateDuplicateFieldValue.js: Cannot read property 'start' of undefined at Generator._printComments (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:667:48) at Generator._printLeadingComments (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:530:10) at Generator.print (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:403:10) at Generator.printJoin (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:479:12) at Generator.printList (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:554:17) at Generator.CallExpression (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/generators/expressions.js:216:8) ``` See https://stackoverflow.com/questions/52087421/module-build-failed-from-node-modules-babel-loader-lib-index-js-typeerror Refs FOLIO-3610 --- CHANGELOG.md | 4 ++++ package.json | 2 ++ 2 files changed, 6 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 395a5e22b1..615d76e5c7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Change history for platform-complete +# 2022-R3 (IN PROGRESS) + +* Provide `@babel/core` and `@babel/preset-env` dev-deps. Refs FOLIO-3610. + ## 1.0.0 (IN PROGRESS) * Add oai-pmh module. Refs MODOAIPMH-94. * Add `ui-plugin-create-inventory-records` to the list of dependencies and modules. diff --git a/package.json b/package.json index 62ea9b65f5..ab61f81073 100644 --- a/package.json +++ b/package.json @@ -90,6 +90,8 @@ "swr": "^0.4.2" }, "devDependencies": { + "@babel/core": "^7.19.3", + "@babel/preset-env": "^7.19.4", "@folio/stripes-cli": "^2.0.0", "eslint": "^6.2.1", "lodash": "^4.17.5" From 862e27ec020fad801450cc0c46a9965935f8ec32 Mon Sep 17 00:00:00 2001 From: Zak Burke Date: Mon, 10 Oct 2022 09:56:32 -0400 Subject: [PATCH 2/2] lock to @babel/generator 7.19.3 Lock to `@babel/generator` `7.19.3`, avoiding the recent `.4` release. h/t @BogdanDenis for pointing out this release. --- package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package.json b/package.json index ab61f81073..c1bb6a9d85 100644 --- a/package.json +++ b/package.json @@ -90,13 +90,12 @@ "swr": "^0.4.2" }, "devDependencies": { - "@babel/core": "^7.19.3", - "@babel/preset-env": "^7.19.4", "@folio/stripes-cli": "^2.0.0", "eslint": "^6.2.1", "lodash": "^4.17.5" }, "resolutions": { + "@babel/generator": "7.19.3", "@folio/stripes-cli": "^2.4.0", "@rehooks/local-storage": "2.4.0", "colors": "1.4.0",