Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Style Guide for Best Practices, Coding Guidelines #47

Open
xlogix opened this issue Mar 1, 2020 · 8 comments
Open

Add Style Guide for Best Practices, Coding Guidelines #47

xlogix opened this issue Mar 1, 2020 · 8 comments
Labels
beginner For Contributors CH20 Hakincodes good first issue Good for newcomers

Comments

@xlogix
Copy link
Member

xlogix commented Mar 1, 2020

No description provided.

@xlogix xlogix added good first issue Good for newcomers beginner For Contributors gssoc20 For GSSoC Contributions labels Mar 1, 2020
@xlogix xlogix added this to To do in Project Footsteps via automation Mar 1, 2020
@huonggiangbui
Copy link

I am interested in this issue. Can you @xlogix tell me more specific description about what I have to do and what expected to be? Thanks!

@xlogix
Copy link
Member Author

xlogix commented Mar 1, 2020

@huonggiangbui We want to add issue templates, PR templates & style guides for the code.
Check out Oppia project for reference. https://github.com/oppia/oppia/

@tarun-nagpal-github
Copy link
Collaborator

@xlogix

I have added the react style guide in the Wiki Page.

People can follow that to write better code into React. Below is the link as well.

https://github.com/airbnb/javascript/tree/master/react

@xlogix
Copy link
Member Author

xlogix commented Mar 2, 2020

Hey Tarun, thanks for linking the guidelines but I think we should directly add a page with the guidelines and add a source link at the bottom.

Also, did you take a look at issue templates? Or Pull request templates? We could add those too

@tarun-nagpal-github
Copy link
Collaborator

Sure @xlogix , I will create a page for the guidelines.

I am working on the other two.

@suntwalriya
Copy link

Is this issue assigned to someone, or can I work on it?

@xlogix
Copy link
Member Author

xlogix commented Mar 8, 2020

@carrisunrio Go ahead!

@tarun-nagpal-github
Copy link
Collaborator

@xlogix @carrisunrio

I have added the WIKI page for "React Style guide and best practices"

https://github.com/fnplus/footsteps-app/wiki/React---Style-guide-and-best-practices

@xlogix xlogix added CH20 Hakincodes and removed gssoc20 For GSSoC Contributions labels Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner For Contributors CH20 Hakincodes good first issue Good for newcomers
Projects
Development

No branches or pull requests

4 participants