Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error for 3.0.0.rc14 #419

Closed
karlhe opened this issue Aug 30, 2016 · 4 comments
Closed

Syntax error for 3.0.0.rc14 #419

karlhe opened this issue Aug 30, 2016 · 4 comments

Comments

@karlhe
Copy link

karlhe commented Aug 30, 2016

I get the following error on JRuby 1.7 (Ruby 1.9.3 mode)

SyntaxError: C:/tools/jruby-1.7.24/lib/ruby/gems/shared/gems/i18n-js-3.0.0.rc14/lib/i18n/js/engine.rb:36: syntax error, unexpected tLPAREN_ARG
        when -> (v) { v2_only.match?("", v) || v3_plus.match?("", v) }

I'm guessing this is syntax specific to ruby > 2.0?

Does not happen with 3.0.0.rc13 or earlier.

@PikachuEXE
Copy link

I am not sure what to do here
For me I prefer changing required_ruby_version to >= 2.0.0
Since 1.9 is EOL more than a year ago
Also we do not test against 1.9.3 (on travis)

@karlhe
Copy link
Author

karlhe commented Aug 31, 2016

Yeah honestly, I don't want to be on this version of JRuby either, but I'm stuck on it until IBM Java fixes an incompatibility with the newer JRuby...

Assuming this is the only line where it's an issue, it seems like all that would be needed is to revert to a syntax compatible with both versions:

lambda{ |v| v2_only.match?("", v) || v3_plus.match?("", v) }

Assuming nothing else has broken yet, although I understand if you want to up the minimum Ruby version. If you're willing to hold out a tad longer, JRuby 1.7 is EOL at the end of the year: jruby/jruby#4112

@PikachuEXE
Copy link

Just changed that line to use old syntax
a2ce930

@karlhe
Copy link
Author

karlhe commented Sep 20, 2016

Sorry on late response. Looks like that was all there was too it, I'll update again if anything else crops up. Thanks!

@karlhe karlhe closed this as completed Sep 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants