Update design for footer notification #522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 Hey, there. Big fan of this gem, it's super helpful.
This PR updates the design of the footer notification for displaying bullet warnings to be less intrusive, but still noticeable.
Old design:
New design:
The footer now uses native
<detail>
and<summary>
tags so it can be opened and closed by clicking the "Bullet Warnings" heading.I've modeled the design after the footer badge from
rack-mini-profiler
, which I really like.