Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename whitelist to safelist #511

Merged
merged 3 commits into from Aug 16, 2021
Merged

Rename whitelist to safelist #511

merged 3 commits into from Aug 16, 2021

Conversation

rhymes
Copy link
Contributor

@rhymes rhymes commented Jun 17, 2020

Renames instances of whitelist to safelist and adds deprecation messages for the previous methods.

See #510

@rhymes rhymes marked this pull request as ready for review June 17, 2020 13:27
@janklimo
Copy link
Contributor

@rhymes thank you for this PR. Suggestion: allowlist might be a more fitting term as suggested by Rubocop. My thinking is that there is nothing unsafe about the listed calls. Instead, we allow/disallow their usage. What are your thoughts on this @flyerhzm?

@rhymes
Copy link
Contributor Author

rhymes commented Aug 16, 2021

@janklimo @flyerhzm make sense to me, let me know what your final decision is and I'll amend the PR

@flyerhzm flyerhzm merged commit 0658d53 into flyerhzm:master Aug 16, 2021
@rhymes rhymes deleted the rhymes/rename-whitelist-to-safelist branch August 16, 2021 13:00
@flyerhzm
Copy link
Owner

@rhymes @janklimo I've merged the PR and released a new version.

btw, I added a new synvert snippet to convert the change automatically in your repos

gem install synvert
synvert --sync

synvert -r bullet/rename_whitelist_to_safelist <repo path>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants