Handle unpersisted primary key values #448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes here:
Object#primary_key_value
toObject#bullet_primary_key_value
to make it clear that this core extension is specific tobullet
and to avoid potential naming conflicts. (This feels at least to me like a semi-private method that shouldn't be used by external code...)Here's a very contrived example:
Previously, bullet would prevent this test case from passing, even though the model does not get persisted at all, simply because the
id
value is present. This change allows bullet to additionally rely onpersisted?
(if it is defined) to decide whether a record might be subject to N+1 issues, etc.