Make Rails check more specific #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In one of our non-Rails projects we added ActionMailer. It comes along with a number of dependencies and modules namespaced under `Rails`. The problem is that we don't have a Rails app and therefore `Rails.root` is not defined. This causes bullet to blow up when getting `Rails.root`. The fix is to be more specific with the check. I also consolidated the logic to one method since `rails?` was only ever used to check if Bullet should call `Rails.root`.
paulcsmith
commented
Jan 18, 2019
| @@ -63,6 +63,10 @@ def enable? | |||
| !!@enable | |||
| end | |||
|
|
|||
| def app_root | |||
There was a problem hiding this comment.
I also moved the logic to one method that can be shared. This way we're not duplicating code across bullet. I hope this was an ok change to make
|
Found this PR because we have a similar need. We're actually using bullet inside of a Rails engine, and while most of our code is in Like, during configuration: Bullet.app_root = Dir.pwd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of our non-Rails projects we added ActionMailer. It comes along
with a number of dependencies and modules namespaced under
Rails.The problem is that we don't have a Rails app and therefore
Rails.rootis not defined. This causes bullet to blow up when getting
Rails.root.The fix is to be more specific with the check. I also consolidated the
logic to one method since
rails?was only ever used to check if Bulletshould call
Rails.root. A similar approach is taken in many other libraries and seems to work well: https://github.com/search?q=defined%3F%28Rails.root&type=Code