Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a flag to limit the max size of Flux artifacts #901

Open
stefanprodan opened this issue Sep 16, 2022 · 0 comments · May be fixed by #929
Open

Introduce a flag to limit the max size of Flux artifacts #901

stefanprodan opened this issue Sep 16, 2022 · 0 comments · May be fixed by #929
Labels
enhancement New feature or request

Comments

@stefanprodan
Copy link
Member

stefanprodan commented Sep 16, 2022

To avoid OOM errors like the one reported here, I think we need to introduce a flag for limiting the size of artifacts produced by source-controller (we do have such a flag but only for Helm artifacts).

Proposal (breaking change)

Add a flag --artifact-max-size with the default set to 50MiB (same default as for --helm-index-max-size).

If the max limit is reached, the controller should fail to reconcile the source and error out with a message that invites users to setup spec.ignore and exclude non-Kubernetes files. Depending on the source type we should link to one of the following docs:

@stefanprodan stefanprodan added the enhancement New feature or request label Sep 16, 2022
@stefanprodan stefanprodan linked a pull request Oct 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant