Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unique (HelmChart) Artifact URLs #610

Open
hiddeco opened this issue Mar 11, 2022 · 0 comments · May be fixed by #611
Open

Unique (HelmChart) Artifact URLs #610

hiddeco opened this issue Mar 11, 2022 · 0 comments · May be fixed by #611
Labels
area/helm Helm related issues and pull requests enhancement New feature or request

Comments

@hiddeco
Copy link
Member

hiddeco commented Mar 11, 2022

At present, the Artifact file name (and thus URL) is composed out of just chart metadata. Due to the way Helm chart builds are not reproducable, this may cause issues on the consumer side when a chart is rebuild due to e.g. a controller restart, but advertised on the same URL. As this causes a mismatch in the checksum calculation.

Given a checksum mismatch error triggers a lot more red flags for an operator than a temporary "404 not found", it would be good idea to add some randomness to the advertised Artifact URL.

To my knowledge, only HelmCharts are affected by this, as other resources strip data (e.g. timestamps).
@hiddeco hiddeco added enhancement New feature or request area/helm Helm related issues and pull requests labels Mar 11, 2022
hiddeco added a commit that referenced this issue Mar 11, 2022
@hiddeco
controllers: store HelmChart Artifact with suffix
87bc4ab 
This adds a Unix suffix to the HelmChart Artifact filename, to ensure
it is unique for sequential builds triggered due to e.g. a controller
restart.

The result of this is that consumers who _think_ they are fetching an
artifact with a certain checksum run into a 404 when attempting to
download a previously advertised but now unavailable file, instead of
running into a checksum validation error (due to non-repetitive Helm
builds).

For more information, see:
#610

Signed-off-by: Hidde Beydals <hello@hidde.co>
@hiddeco hiddeco linked a pull request Mar 11, 2022 that will close this issue
Draft
hiddeco added a commit that referenced this issue Mar 11, 2022
@hiddeco
controllers: store HelmChart Artifact with suffix
6ebe460 
This adds a Unix suffix to the HelmChart Artifact filename, to ensure
it is unique for sequential builds triggered due to e.g. a controller
restart.

The result of this is that consumers who _think_ they are fetching an
Artifact with a certain checksum run into a 404 when attempting to
download a previously advertised but now unavailable file, instead of
running into a checksum validation error (due to non-repetitive Helm
builds).

For more information, see:
#610

Signed-off-by: Hidde Beydals <hello@hidde.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/helm Helm related issues and pull requests enhancement New feature or request
Projects
Maintainers' Focus
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

controllers: store HelmChart Artifact with suffix fluxcd/source-controller
1 participant
@hiddeco