Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port Ginkgo tests to pkg/runtime/testenv #325

Closed
hiddeco opened this issue Oct 1, 2021 · 1 comment
Closed

Port Ginkgo tests to pkg/runtime/testenv #325

hiddeco opened this issue Oct 1, 2021 · 1 comment
Labels
area/ci CI related issues and pull requests enhancement New feature or request

Comments

@hiddeco
Copy link
Member

hiddeco commented Oct 1, 2021

We are dropping Ginkgo across controllers for testing because it introduced a lot of complexity and a way of writing test no-one till date really liked. As a replacement, testenv should be used to write Go idiomatic tests.

Work like #322 likely has to go first.

An example of such a port for another controller can be found here: fluxcd/image-automation-controller#221

@hiddeco hiddeco added the enhancement New feature or request label Oct 1, 2021
@hiddeco hiddeco added the area/ci CI related issues and pull requests label Oct 1, 2021
@stefanprodan
Copy link
Member

Implemented in #738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants