Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gitlab Tree client implementation doesn't support pagination #158

Open
ranatrk opened this issue Aug 9, 2022 · 0 comments
Open

Gitlab Tree client implementation doesn't support pagination #158

ranatrk opened this issue Aug 9, 2022 · 0 comments

Comments

@ranatrk
Copy link
Contributor

ranatrk commented Aug 9, 2022

Describe the bug

  • Gitlab tree is implemented in a pull request.

  • The gitlab client uses the xanzy/go-gitlab module which doesn't support the pagination using keyset mentioned in the gitlab tree docs and gitlab keyset docs. This is based on an existing issue in xanzy/go-gitlab

  • The current maximum number of files retrieved from gitlab trees is 100 files per request.

To Reproduce

Retrieving a tree with more than 100 files+directories combined using the tree client

Expected behavior

Pagination implemented for gitlab tree list(either the user requesting following pages, or internally until all results are retrieved with a maximum number of pages used to limit recursivness)

Additional context

  • Go version: go1.18
  • Git provider: Implemented in pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant