Add validation to namespace flag #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
stefanprodan
reviewed
Aug 8, 2022
pjbgf
pushed a commit
to pjbgf/pkg
that referenced
this pull request
Aug 8, 2022
The broken symlinks used for tests broke the use of fluxcd/pkg as a GitHub action, as pointed out in: fluxcd/flux2#2964 This creates and removes such symlinks on demand to ensure the tests are still catered for, without impacting the GitHub actions. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
pjbgf
pushed a commit
to pjbgf/pkg
that referenced
this pull request
Aug 8, 2022
The broken symlinks used for tests broke the use of fluxcd/pkg as a GitHub action, as pointed out in: fluxcd/flux2#2964 This creates and removes such symlinks on demand to ensure the tests are still catered for, without impacting the GitHub actions. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
pjbgf
force-pushed
the
clean-up
branch
2 times, most recently
from
372feb1
to
223e176
Compare
Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
stefanprodan
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.