SRCINFO: fix path #2917
Merged
SRCINFO: fix path #2917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ciaran Moran <ciaran@weave.works>
Signed-off-by: Ciaran Moran <ciaran@weave.works>
hiddeco
approved these changes
Jul 18, 2022
hiddeco
added a commit
that referenced
this pull request
Jul 28, 2022
Due to the release CI job running on an Ubuntu machine, we do not have easy access to `makepkg` to generate the `.SRCINFO` using `--printsrcinfo` as this is a `pacman` specific utility. Historically seen, something went wrong here while the `PKGBUILD` file became more complex and certain fields added there where not included in the `.SRCINFO` template. This commit ensures everything is restored to working state, and provides the proper fix for what was attempted in #2917. In addition, checksums are now included in the file. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
added a commit
that referenced
this pull request
Jul 28, 2022
Due to the release CI job running on an Ubuntu machine, we do not have easy access to `makepkg` to generate the `.SRCINFO` using `--printsrcinfo` as this is a `pacman` specific utility. Historically seen, something went wrong here while the `PKGBUILD` file became more complex and certain fields added there were not _also_ included in the `.SRCINFO` template. This commit ensures everything is restored to working state, and provides the proper fix for what was attempted in #2917. In addition, checksums are now included in the file. Signed-off-by: Hidde Beydals <hello@hidde.co>
hiddeco
added a commit
that referenced
this pull request
Jul 28, 2022
Due to the release CI job running on an Ubuntu machine, we do not have easy access to `makepkg` to generate the `.SRCINFO` using `--printsrcinfo` as this is a `pacman` specific utility, and instead we maintain a template. Historically seen, something went wrong here while the `PKGBUILD` file became more complex and certain fields added there were not _also_ included in the `.SRCINFO` template. This commit ensures everything is restored to working state, and provides the proper fix for what was attempted in #2917. In addition, checksums are now included in the file. Signed-off-by: Hidde Beydals <hello@hidde.co>
raffis
pushed a commit
to raffis/flux2
that referenced
this pull request
Jan 10, 2023
Due to the release CI job running on an Ubuntu machine, we do not have easy access to `makepkg` to generate the `.SRCINFO` using `--printsrcinfo` as this is a `pacman` specific utility, and instead we maintain a template. Historically seen, something went wrong here while the `PKGBUILD` file became more complex and certain fields added there were not _also_ included in the `.SRCINFO` template. This commit ensures everything is restored to working state, and provides the proper fix for what was attempted in fluxcd#2917. In addition, checksums are now included in the file. Signed-off-by: Hidde Beydals <hello@hidde.co>
souleb
pushed a commit
to souleb/flux2
that referenced
this pull request
Jul 10, 2023
Due to the release CI job running on an Ubuntu machine, we do not have easy access to `makepkg` to generate the `.SRCINFO` using `--printsrcinfo` as this is a `pacman` specific utility, and instead we maintain a template. Historically seen, something went wrong here while the `PKGBUILD` file became more complex and certain fields added there were not _also_ included in the `.SRCINFO` template. This commit ensures everything is restored to working state, and provides the proper fix for what was attempted in fluxcd#2917. In addition, checksums are now included in the file. Signed-off-by: Hidde Beydals <hello@hidde.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon noticing pkgrel = 2 of pkgver = 0.31.4 has broken SHAs for amd64, I also noticed the templates appear to need release URLs updating.