Handle secret types properly while masking sops data #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souleb
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
Thanks @aryan9600 for working on this. That looks good. But in issue #2535, the example given by the reporter contains the type, we might want to have him validate this.
|
Yep, I was able to repro the issue on my local and confirm that these changes fix the issue. @nickperkins could you confirm validate it as well if possible? |
souleb
added
area/diff
hiddeco
approved these changes
Apr 19, 2022
There was a problem hiding this comment.
This looks good to me, but is in need of a rebase. Thanks @aryan9600 🙇
Signed-off-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
aryan9600
force-pushed
the
fix-mask-sops
branch
from
1af13ad
to
5c9cbe6
Compare
This seems to have fixed the issue on my side. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2535
Signed-off-by: Sanskar Jaiswal jaiswalsanskar078@gmail.com