Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchancement: better control of loggers #57

Closed
vsoch opened this issue Dec 28, 2022 · 3 comments
Closed

Enchancement: better control of loggers #57

vsoch opened this issue Dec 28, 2022 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@vsoch
Copy link
Member

vsoch commented Dec 28, 2022

Currently, when we start with four (or more) workers, we see the equivalent in logging:

image

It looks like there is a way to remove the root logger (that passes on to the workers) and just use one logger tiangolo/fastapi#1508 (comment). It's not huge priority because it's mostly aesthetic, but if someone wants to grab this (before I do) that would be great!

@vsoch vsoch added the help wanted Extra attention is needed label Dec 28, 2022
@vsoch
Copy link
Member Author

vsoch commented Dec 28, 2022

okay closer inspection I think flux is doing this - when I run with N>1 workers just locally (without flux start) I don't see any issue.

@vsoch vsoch transferred this issue from flux-framework/flux-restful-api Dec 28, 2022
@vsoch
Copy link
Member Author

vsoch commented Dec 28, 2022

Transferred to operator - this seems to be an artifact of flux start being given uvicorn. I can't reproduce running uvicorn with the server alone.

@vsoch
Copy link
Member Author

vsoch commented Feb 18, 2023

I think this is resolved. It would be good to parse apart the timing logs from the job logs, but that's for another day.

@vsoch vsoch closed this as completed Feb 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant