Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package ships with no_sleep.js file on all platforms #5

Open
ened opened this issue Aug 17, 2023 · 1 comment
Open

Package ships with no_sleep.js file on all platforms #5

ened opened this issue Aug 17, 2023 · 1 comment

Comments

@ened
Copy link

ened commented Aug 17, 2023

This no_sleep.js file should only be used for web projects (and perhaps be compressed as well).

Screenshot 2023-08-17 at 10 31 32
@diegotori
Copy link
Collaborator

diegotori commented Aug 17, 2023

@ened thank you for your question. The web version is a consolidation of the original wakelock plugin that federated each platform into its own package. As a result, it adds this script, but rest assured, its only ever used in web.

Not to mention that the size of the script is negligible in terms of footprint due to it being part of the implementation.

Lastly, there is currently an open issue for the Flutter team to add support for platform-specific assets. However, no movement has been made on that issue thus far. Feel free to give it a thumbs up so that it gets their attention.

In terms of compressing that script in question, I dunno how to specifically do that for JavaScript files. However, I do accept PRs to that effect and will review them once submitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants