Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap #379

Open
7 of 18 tasks
RatakondalaArun opened this issue Jul 23, 2022 · 16 comments
Open
7 of 18 tasks

Roadmap #379

RatakondalaArun opened this issue Jul 23, 2022 · 16 comments

Comments

@RatakondalaArun
Copy link
Collaborator

RatakondalaArun commented Jul 23, 2022

Good to have

@RatakondalaArun RatakondalaArun pinned this issue Jul 23, 2022
@RatakondalaArun
Copy link
Collaborator Author

RatakondalaArun commented Jul 23, 2022

@MarkOSullivan94 @bradintheusa

Please feel free to edit missing items to this list

@MarkOSullivan94
Copy link
Collaborator

MarkOSullivan94 commented Jul 28, 2022

@RatakondalaArun I think it's a good time to publish a new release and test out the GitHub action for automatically deploying a new release to Pub

Think it's good to update to 0.10.0 for this release and then any bug fixes will be 0.10.x.

Want open a PR with all the necessary changes (pubspec.yaml, README.md, CHANGELOG.md) and then we can test it out?

@RatakondalaArun
Copy link
Collaborator Author

I think we need to fix #384 before the release of v0.10.0. All new projects are affected by this issue.

@RatakondalaArun
Copy link
Collaborator Author

Want open a PR with all the necessary changes (pubspec.yaml, README.md, CHANGELOG.md) and then we can test it out?

Is there any way to automate these updates? The way I see we have most of the info

  • pubspec.yaml: We can get the package version from the GitHub release tag
  • CHANGELOG.md: we can get the changelog from the GitHub release tag description
  • README.md: these get updated when needed by a feature release

@MarkOSullivan94
Copy link
Collaborator

MarkOSullivan94 commented Aug 1, 2022

Want open a PR with all the necessary changes (pubspec.yaml, README.md, CHANGELOG.md) and then we can test it out?

Is there any way to automate these updates? The way I see we have most of the info

  • pubspec.yaml: We can get the package version from the GitHub release tag
  • CHANGELOG.md: we can get the changelog from the GitHub release tag description
  • README.md: these get updated when needed by a feature release

1. CHANGELOG.md

I've noticed there's a nice new feature when publishing new GitHub releases that automatically generates a change log so that would take care of CHANGELOD.md

2. pubspec.yaml / versioning

For versioning we could suggest for contributors to use cider - I haven't used it before but it looks like it should fit our use case.

We need to bump the version before publishing a new GitHub release due to our CD pipeline where we try to automatically publish a new version to pub with GitHub Actions because we'll run into issues trying to republish the same version

3. README.md

Perhaps this is one for us to pay attention to during the PR process or maybe have a template for new PRs which encourage people to update the README.md if it's introducing a new feature, what do you think @RatakondalaArun?

@MarkOSullivan94
Copy link
Collaborator

MarkOSullivan94 commented Aug 5, 2022

@RatakondalaArun I deleted the old published release because it didn't upload to Pub due to x3 failing tests, you can see these here: https://github.com/fluttercommunity/flutter_launcher_icons/actions/runs/2798119853

The package_version_test.dart was failing because build runner wasn't run to update the generated package version, I've fixed that and amended the last commit and then forced pushed to master

Since then I've published another v0.10.0 which has triggered the action and we have all of the tests passing now but it has failed the dry run: https://github.com/fluttercommunity/flutter_launcher_icons/runs/7683629796

@RatakondalaArun
Copy link
Collaborator Author

Packages with an SDK constraint on a pre-release of the Dart SDK should themselves be published as a pre-release version. If this package needs Dart version 2.12.0-0, consider publishing the package as a pre-release instead.
See https://dart.dev/tools/pub/publishing#publishing-prereleases For more information on pre-releases

We need to update pubspec.yaml

environment:
sdk: ">=2.12.0-0 <3.0.0"

@MarkOSullivan94
Copy link
Collaborator

Packages with an SDK constraint on a pre-release of the Dart SDK should themselves be published as a pre-release version. If this package needs Dart version 2.12.0-0, consider publishing the package as a pre-release instead.
See https://dart.dev/tools/pub/publishing#publishing-prereleases For more information on pre-releases

We need to update pubspec.yaml

environment:
sdk: ">=2.12.0-0 <3.0.0"

Updated pubspec.yaml and amended the last commit, the GitHub action ran successfully and v0.10.0 is now publicly available 🥳

@RatakondalaArun
Copy link
Collaborator Author

Great🎉 I also created a milestone for next release https://github.com/fluttercommunity/flutter_launcher_icons/milestone/2

@MarkOSullivan94
Copy link
Collaborator

MarkOSullivan94 commented Aug 8, 2022

@RatakondalaArun we should prioritise both #401 and #402 to ensure flutter_launcher_icons is receiving the best possible score from pub.dev

Whilst #403 will not improve the score on pub.dev, I still feel that should also be an high priority to address

@RatakondalaArun
Copy link
Collaborator Author

@MarkOSullivan94 Let's release a new version with support for macos and a few fixes

@OutdatedGuy
Copy link
Contributor

@MarkOSullivan94, the Add .pub_ignore to ignore unrelated folders like test task is done right? If yes, please tick it here

@MarkOSullivan94
Copy link
Collaborator

@OutdatedGuy yep that's done, ticked it now, thanks for pointing that out

@OutdatedGuy
Copy link
Contributor

@MarkOSullivan94 can you tick generate config file task.

@MarkOSullivan94
Copy link
Collaborator

Done thanks @OutdatedGuy

@MarkOSullivan94
Copy link
Collaborator

Added #466 to the roadmap as a good to have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants