-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update delete-data.md #10585
Update delete-data.md #10585
Conversation
Fix "Delete data on the internet" cookbook sample. The Album.fromJson method doesn't handle an empty map, which is returned from the jsonplaceholder API when the DELETE method is called. Fixes #10577
Visit the preview URL for this PR (updated for commit b170310): https://flutter-docs-prod--pr10585-i10577-fix-delete-data-cook-ait7z927.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! But you'll need to update the source snippets as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once @parlough's concerns are addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, once the build succeeds.
Fix "Delete data on the internet" cookbook sample. The Album.fromJson method doesn't handle an empty map, which is returned from the jsonplaceholder API when the DELETE method is called. Fixes #10577 --------- Co-authored-by: Parker Lougheed <parlough@gmail.com>
Fix "Delete data on the internet" cookbook sample.
The Album.fromJson method doesn't handle an empty map, which is returned from the jsonplaceholder API when the DELETE method is called.
Fixes #10577