Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update delete-data.md #10585

Merged
merged 3 commits into from
May 14, 2024
Merged

Update delete-data.md #10585

merged 3 commits into from
May 14, 2024

Conversation

johnpryan
Copy link
Contributor

Fix "Delete data on the internet" cookbook sample.

The Album.fromJson method doesn't handle an empty map, which is returned from the jsonplaceholder API when the DELETE method is called.

Fixes #10577

Fix "Delete data on the internet" cookbook sample.

The Album.fromJson method doesn't handle an empty map, which is returned from the jsonplaceholder API when the DELETE method is called. 

Fixes #10577
@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented May 13, 2024

Visit the preview URL for this PR (updated for commit b170310):

https://flutter-docs-prod--pr10585-i10577-fix-delete-data-cook-ait7z927.web.app

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But you'll need to update the source snippets as well.

Copy link
Contributor

@domesticmouse domesticmouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once @parlough's concerns are addressed

@johnpryan johnpryan requested a review from khanhnwin as a code owner May 13, 2024 23:55
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, once the build succeeds.

@parlough parlough merged commit d822d0a into main May 14, 2024
9 checks passed
@parlough parlough deleted the i10577-fix-delete-data-cookbook branch May 14, 2024 04:45
sfshaza2 pushed a commit that referenced this pull request May 14, 2024
Fix "Delete data on the internet" cookbook sample.

The Album.fromJson method doesn't handle an empty map, which is returned
from the jsonplaceholder API when the DELETE method is called.

Fixes #10577

---------

Co-authored-by: Parker Lougheed <parlough@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PAGE ISSUE]: 'Delete data on the internet'
5 participants