Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing setting to 'Deprecated imperative apply of Flutter's Gradle plugins' page #10528

Open
1 task done
ArocaAlejandro opened this issue May 8, 2024 · 0 comments
Open
1 task done
Labels
a.rn.breaking-changes Relates to breaking changes on a Flutter release e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged target.Android Target apps on the Android Platform

Comments

@ArocaAlejandro
Copy link

Page URL

https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply/

Page source

https://github.com/flutter/website/tree/main/src/content/release/breaking-changes/flutter-gradle-plugin-apply.md

Describe the problem

Missing settings.ext.flutterSdkPath = flutterSdkPath() between fluterSdkPath and includeBuild

Expected fix

def flutterSdkPath = {
    def properties = new Properties()
    file("local.properties").withInputStream { properties.load(it) }
    def flutterSdkPath = properties.getProperty("flutter.sdk")
    assert flutterSdkPath != null, "flutter.sdk not set in local.properties"
    return flutterSdkPath
}
settings.ext.flutterSdkPath = flutterSdkPath()

includeBuild("${settings.ext.flutterSdkPath}/packages/flutter_tools/gradle")

Additional context

No response

I would like to fix this problem.

  • I will try and fix this problem on docs.flutter.dev.
@ArocaAlejandro ArocaAlejandro added the from.page-issue Reported in a reader-filed concern label May 8, 2024
@sfshaza2 sfshaza2 added p2-medium Necessary but not urgent concern. Resolve when possible. e1-hours Effort: < 8 hrs labels May 8, 2024
@atsansone atsansone added st.triage.ltw Indicates Lead Tech Writer has triaged target.Android Target apps on the Android Platform a.rn.breaking-changes Relates to breaking changes on a Flutter release labels May 8, 2024
@atsansone atsansone changed the title [PAGE ISSUE]: 'Deprecated imperative apply of Flutter's Gradle plugins' Add missing setting to 'Deprecated imperative apply of Flutter's Gradle plugins' page May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a.rn.breaking-changes Relates to breaking changes on a Flutter release e1-hours Effort: < 8 hrs from.page-issue Reported in a reader-filed concern p2-medium Necessary but not urgent concern. Resolve when possible. st.triage.ltw Indicates Lead Tech Writer has triaged target.Android Target apps on the Android Platform
Projects
None yet
Development

No branches or pull requests

3 participants