You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm going to be using this issue to find and track issues with the sample, then determine if they're caused by wasm compilation, skwasm, the sample itself, browser support, or Flutter. If an issue is not open for any issues found, I will open one in the appropriate repository and link to it from here.
If you make a selection in the search bar, leave it with tab focus, then return with tab focus and push "Enter", focus is lost? If you focus the search bar, then press "Enter", focus is lost and returned to the beginning of the app.
I determined these issues are likely because of the sample itself.
Tab order in wide screen/expanded navigation menu is wrong.
It seems to be going by column rather than row?
In the search anchor search view, "No search history" is too low contrast and positioned too close to the divider.
If you open "Show bottom sheet" then close it by dragging or the back button in the upper right, the text button will still say "Hide bottom sheet" despite it already being hidden.
In the "Text fields" section, the X/close buttons added to each should only appear once text is added and they should have a little margin from the right.
Browser(s)
Annoying warning about WebGL extension support from Chrome
WebGL: this extension has very low support on mobile devices; do not rely on it for rendering effects: WEBGL_polygon_mode
Undetermined issues
Not sure
Uncaught TypeError: Cannot read properties of null (reading 'ds'...
I can't reproduce. Might have been fixed.
Still working to find more discrepancies
Typing in text input boxes on narrow, short screen moves page up
Sample or Flutter
I determined these issues impact the sample whether running with Wasm or not. I still need to determine if they are because of Flutter or because of the sample.
Sometimes after resizing the window, can't scroll down all the way
parlough
changed the title
Fix m3 demo issues when running with wasm and skwasm
Identify M3 demo sample issues, determine source of each, and file relevant issues
Jan 11, 2024
Hi all! I've gone through the Material 3 demo sample to find various issues, then determine if they are caused by dart2wasm compilation, the skwasm renderer, Flutter, or the sample itself.
You can find each of these issues above organized within those categories. Each issue has a link to the corresponding Flutter or Dart issue(s) I filed for them, as well as to the relevant fix if that's been made.
\cc @kevmoo For awareness about the various skwasm issues. As for dart2wasm with or without skwasm, it resulted in only one issue unique to it, and I was able to fix that in the SDK.
\cc @QuncCccccc For awareness and potentially help with resolving the sample and framework issues.
I'm going to be using this issue to find and track issues with the sample, then determine if they're caused by wasm compilation, skwasm, the sample itself, browser support, or Flutter. If an issue is not open for any issues found, I will open one in the appropriate repository and link to it from here.
Code: https://github.com/flutter/samples/tree/main/material_3_demo
Version: HEAD on
main
Staged: https://parlough-testing-skwasm.web.app/
Determined issues
Wasm build
These issues happen with
flutter build web --wasm
(using CanvasKit).DateTime.timeZoneOffset
has the wrong sign dart-lang/sdk#54448skwasm
rendererThese issues happen with
flutter build web --wasm --web-renderer=skwasm
.ColorScheme.fromImageProvider
always produces the same result flutter#141326ActionChip
and disabledInputChip
aren't rendering their contentsActionChip
with label and avatar fails to render contents flutter#140999InputChip
is improperly locatedInputChip
delete icon hover square is not centered flutter#141000Flutter (framework or engine)
I determined these issues affect all Flutter backends, at least web and desktop.
InputChip
has square background on hover inconsistent with ink splash.InputChip
shows delete even though it's not interactableonDeleted
callback shows "Delete" tooltip on hover flutter#141336DatePickerDialog
"Switch to input" button has no margin from dialog side flutter#141338DatePickerDialog
has unnecessary scrollbar on months with 6 rows flutter#141348DatePickerDialog
date entry hover background and ink splash have different radius flutter#141350ProgressIndicator
for Material 3 redesign flutter#141340SnackBar
"Close" text hover surface is (almost) impossible to see in light and dark themesSnackBar
action hover state background too hard to see flutter#141343TextField
styles result in cursor overlappinglabelText
flutter#141354SearchAnchor
search view clear button shows up even if you haven't entered any text flutter#141346SearchAnchor
search view close and clear buttons don't have hover tooltips flutter#141347SearchAnchor.bar
loses focus flutter#141395showBottomSheet
should have ashowDragHandle
option likeshowModalBottomSheet
flutter#141353AppBar
back button focus/hover circle should not fill up whole height flutter#141361Sample
I determined these issues are likely because of the sample itself.
Browser(s)
Undetermined issues
Not sure
Uncaught TypeError: Cannot read properties of null (reading 'ds'...
Sample or Flutter
I determined these issues impact the sample whether running with Wasm or not. I still need to determine if they are because of Flutter or because of the sample.
The text was updated successfully, but these errors were encountered: