[image_picker: ^1.1.0] Android 12+ image viewer crashes when no images are passed to selected images #147280

Biowulf21 · 2024-04-24T02:48:33Z

Steps to reproduce

EDIT: I am using the pickMultiImage function

Click button to open image_picker on android 13
Select a single image
Click View Selected on lower left side of screen
Click Selected button to unselect the single image (add button will reflect 0 images selected)
Click add button

Expected results

Image picker should close when this flow is done, as tested on native android applications.

Actual results

The app crashes.

Code sample

try {
      final picker = ImagePicker();
      final permissionStatus =
          await ImagesUtils.getPhotoPickingPermissionStatus(source);

      if (permissionStatus.isGranted || permissionStatus.isLimited) {
        final image = await picker.pickImage(source: source);
}

} catch (e){
print(e);
}

Screenshots or Video

Logs

E/AndroidRuntime(25551): java.lang.NullPointerException: uri
E/AndroidRuntime(25551): 	at java.util.Objects.requireNonNull(Objects.java:232)
E/AndroidRuntime(25551): 	at android.content.ContentResolver.openInputStream(ContentResolver.java:1511)
E/AndroidRuntime(25551): 	at io.flutter.plugins.imagepicker.FileUtils.getPathFromUri(FileUtils.java:55)
E/AndroidRuntime(25551): 	at io.flutter.plugins.imagepicker.ImagePickerDelegate.handleChooseMultiImageResult(ImagePickerDelegate.java:707)
E/AndroidRuntime(25551): 	at io.flutter.plugins.imagepicker.ImagePickerDelegate.lambda$onActivityResult$1$io-flutter-plugins-imagepicker-ImagePickerDelegate(ImagePickerDelegate.java:609)
E/AndroidRuntime(25551): 	at io.flutter.plugins.imagepicker.ImagePickerDelegate$$ExternalSyntheticLambda1.run(Unknown Source:6)
E/AndroidRuntime(25551): 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
E/AndroidRuntime(25551): 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:644)
E/AndroidRuntime(25551): 	at java.lang.Thread.run(Thread.java:1012)
I/ViewRootImpl@c3d471f[MainActivity](25551): MSG_WINDOW_FOCUS_CHANGED 1 0
D/ViewRootImpl@c3d471f[MainActivity](25551): mThreadedRenderer.initializeIfNeeded()#2 mSurface={isValid=true 0xb4000073ea96d390}
D/InputMethodManagerUtils(25551): startInputInner - Id : 0
I/InputMethodManager(25551): startInputInner - IInputMethodManagerGlobalInvoker.startInputOrWindowGainedFocus
I/Process (25551): Sending signal. PID: 25551 SIG: 9
Lost connection to device.

Flutter Doctor output

Doctor output

[✓] Flutter (Channel stable, 3.19.5, on macOS 13.6.1 22G313 darwin-arm64, locale en-PH)
    • Flutter version 3.19.5 on channel stable at /Users/jamespatrickjilhaney/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 300451adae (4 weeks ago), 2024-03-27 21:54:07 -0500
    • Engine revision e76c956498
    • Dart version 3.3.3
    • DevTools version 2.31.1

[!] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/jamespatrickjilhaney/Library/Android/sdk
    ✗ cmdline-tools component is missing
      Run `path/to/sdkmanager --install "cmdline-tools;latest"`
      See https://developer.android.com/studio/command-line for more details.
    ✗ Android license status unknown.
      Run `flutter doctor --android-licenses` to accept the SDK licenses.
      See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.14.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.88.0)
    • VS Code at /Users/jamespatrickjilhaney/Downloads/Visual Studio Code.app/Contents
    • Flutter extension version 3.86.0

[✓] Connected device (4 available)
    • SM G996N (mobile)                   • R3CR1068VDD                          • android-arm64  • Android 14 (API 34)
    • iPhone SE (3rd generation) (mobile) • BE33B77B-5993-4F32-807B-1CB29C0F7C13 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-0 (simulator)
    • macOS (desktop)                     • macos                                • darwin-arm64   • macOS 13.6.1 22G313 darwin-arm64
    • Chrome (web)                        • chrome                               • web-javascript • Google Chrome 119.0.6045.105

[✓] Network resources
    • All expected network resources are available.

The text was updated successfully, but these errors were encountered:

danagbemava-nc · 2024-04-24T08:41:50Z

Hi @Biowulf21, is this the only device you're seeing it on or are other devices affected? I tested this on my pixel 7 running android 14 and it doesn't allow me to submit 0 items.

Can you also try uprading to the latest version of image_picker to see if you still experience this issue?

Thank you

Biowulf21 · 2024-04-26T11:20:36Z

Hi @Biowulf21, is this the only device you're seeing it on or are other devices affected? I tested this on my pixel 7 running android 14 and it doesn't allow me to submit 0 items.

Can you also try uprading to the latest version of image_picker to see if you still experience this issue?

Thank you

hi @danagbemava-nc , I tested this on my Samsung S21+ and it crashes the app as well. Huawei P30 Pro also crashes per our QA team.

I'll look into the latest version next week. Thank you!

EDIT: Corrected the device models

danagbemava-nc · 2024-04-29T06:14:37Z

~~Please keep us updated~~

@Biowulf21, just to confirm, are you calling pickImage or pickMultiImage? On my pixel 7, with pickImage, there isn't the option to select multiple images, but pickMultiImage does allow me to select multiple images.

Biowulf21 · 2024-04-29T09:12:49Z

Hi @danagbemava-nc I'm using pickMultiImage. So sorry for the delay, I'm out of the house right now, but I'll be sure to update this thread later tonight. Thank you!

Edit: I tested the same flow using the latest image_pickers version (1.1.0) and the issue is still there.

danagbemava-nc · 2024-04-30T07:40:10Z

Thanks for the update. Just to confirm, were the samsung s21+ and the huawei p40 both running android 13? Have you tested this on any other OS version?

Biowulf21 · 2024-05-02T01:50:49Z

Thanks for the update. Just to confirm, were the samsung s21+ and the huawei p40 both running android 13? Have you tested this on any other OS version?

Hello, my team and I tested this on three devices: Huawei P30 Pro (Android 12), Infinix SMART 8 (Android 13), and Samsung 21+ (Android 14).

I also updated the title of the issue for your reference @danagbemava-nc. Sorry for the confusion.

danagbemava-nc · 2024-05-02T06:59:09Z

Thanks for the update.

While I cannot reproduce this on my device (the picker won't allow sending back 0 items), it seems like we are passing a null URI to https://github.com/flutter/packages/blob/6e6082660b73144e5fedf28545602c1ef6588f8e/packages/image_picker/image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/FileUtils.java#L55

I think it would be best to catch the null_pointer exception or check if the uri is null before processing.

Labeling for further insight.

stuartmorgan · 2024-05-09T12:28:18Z

This looks like the same issue that flutter/packages#4836 fixed for single-item selection, where some pickers are, instead of returning no clip data, returning clip data with a null URI. It's not fixed for the multi-item codepath yet (see flutter/packages#4836 (comment) for a suggestion on this).

stuartmorgan · 2024-05-13T15:19:14Z

Re-opening since the PR didn't fix all codepaths. And in particular, the original report's stack is in handleChooseMultiImageResult, which is the one that's not fixed.

Mairramer · 2024-05-13T17:36:41Z

@stuartmorgan @gmackall I created a new PR complementing the one I had previously sent.

LouiseHsu · 2024-05-13T18:46:59Z

i don't remember closing this?

gmackall · 2024-05-13T19:10:49Z

i don't remember closing this?

I think its just a Github bug, I believe updating the main branch on a fork (maybe only with the github ui?) will sometimes re-close an issue when that update pulls in a commit that contains the description "fixes #issue number".

So if a commit gets merged to main saying "fixed..." but then the issue gets re-opened, and then you update your main branch (and pull in the commit) it will sometimes re-close.

gmackall · 2024-05-14T20:45:56Z

This should be fixed by flutter/packages#5009

…er#6691) This will fix flutter/flutter#147280

danagbemava-nc added the in triage Presently being triaged by the triage team label Apr 24, 2024

danagbemava-nc added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 24, 2024

github-actions bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 26, 2024

danagbemava-nc added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 29, 2024

github-actions bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 29, 2024

Biowulf21 changed the title ~~[image_picker: ^1.0.4] Android 13 image viewer crashes when no images are passed to selected images~~ [image_picker: ^1.1.0] Android 13 image viewer crashes when no images are passed to selected images Apr 29, 2024

danagbemava-nc added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Apr 30, 2024

github-actions bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label May 2, 2024

Biowulf21 changed the title ~~[image_picker: ^1.1.0] Android 13 image viewer crashes when no images are passed to selected images~~ [image_picker: ^1.1.0] Android 12+ image viewer crashes when no images are passed to selected images May 2, 2024

This comment was marked as off-topic.

Sign in to view

stuartmorgan added the triaged-ecosystem Triaged by Ecosystem team label May 8, 2024

Mairramer mentioned this issue May 8, 2024

[image_picker_android] - will fix crash on Android 12+ devices flutter/packages#6691

Merged

11 tasks

flutter-triage-bot bot removed fyi-ecosystem For the attention of Ecosystem team triaged-ecosystem Triaged by Ecosystem team labels May 8, 2024

reidbaker added P1 High-priority issues at the top of the work list triaged-android Triaged by Android platform team labels May 9, 2024

auto-submit bot closed this as completed in flutter/packages#6691 May 10, 2024

danagbemava-nc added the r: fixed Issue is closed as already fixed in a newer version label May 13, 2024

stuartmorgan reopened this May 13, 2024

Mairramer mentioned this issue May 13, 2024

[image_picker_android] - fix crash handle choose multi image result flutter/packages#6724

Closed

11 tasks

LouiseHsu closed this as completed in LouiseHsu/packages@f18b895 May 13, 2024

stuartmorgan reopened this May 13, 2024

danagbemava-nc removed the r: fixed Issue is closed as already fixed in a newer version label May 14, 2024

gmackall closed this as completed May 14, 2024

danagbemava-nc added the r: fixed Issue is closed as already fixed in a newer version label May 15, 2024

TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this issue May 22, 2024

[image_picker_android] - will fix crash on Android 12+ devices (flutt…

d61bb9e

…er#6691) This will fix flutter/flutter#147280

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[image_picker: ^1.1.0] Android 12+ image viewer crashes when no images are passed to selected images #147280

[image_picker: ^1.1.0] Android 12+ image viewer crashes when no images are passed to selected images #147280

Biowulf21 commented Apr 24, 2024 •

edited

danagbemava-nc commented Apr 24, 2024

Biowulf21 commented Apr 26, 2024 •

edited

danagbemava-nc commented Apr 29, 2024 •

edited

Biowulf21 commented Apr 29, 2024 •

edited

danagbemava-nc commented Apr 30, 2024

Biowulf21 commented May 2, 2024 •

edited

danagbemava-nc commented May 2, 2024

This comment was marked as off-topic.

This comment was marked as off-topic.

stuartmorgan commented May 9, 2024

stuartmorgan commented May 13, 2024

Mairramer commented May 13, 2024

LouiseHsu commented May 13, 2024

gmackall commented May 13, 2024

gmackall commented May 14, 2024

[image_picker: ^1.1.0] Android 12+ image viewer crashes when no images are passed to selected images #147280

[image_picker: ^1.1.0] Android 12+ image viewer crashes when no images are passed to selected images #147280

Comments

Biowulf21 commented Apr 24, 2024 • edited

Steps to reproduce

Expected results

Actual results

Code sample

Screenshots or Video

Logs

Flutter Doctor output

danagbemava-nc commented Apr 24, 2024

Biowulf21 commented Apr 26, 2024 • edited

danagbemava-nc commented Apr 29, 2024 • edited

Biowulf21 commented Apr 29, 2024 • edited

danagbemava-nc commented Apr 30, 2024

Biowulf21 commented May 2, 2024 • edited

danagbemava-nc commented May 2, 2024

This comment was marked as off-topic.

This comment was marked as off-topic.

stuartmorgan commented May 9, 2024

stuartmorgan commented May 13, 2024

Mairramer commented May 13, 2024

LouiseHsu commented May 13, 2024

gmackall commented May 13, 2024

gmackall commented May 14, 2024

Biowulf21 commented Apr 24, 2024 •

edited

Biowulf21 commented Apr 26, 2024 •

edited

danagbemava-nc commented Apr 29, 2024 •

edited

Biowulf21 commented Apr 29, 2024 •

edited

Biowulf21 commented May 2, 2024 •

edited