Flutter needs to route fuchsia.sysmem2.Allocator #146858
Assignees
Labels
engine
flutter/engine repository. See also e: labels.
P2
Important issues not at the top of the work list
platform-fuchsia
Fuchsia code specifically
team-engine
Owned by Engine team
triaged-engine
Triaged by Engine team
Comments
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
Apr 17, 2024
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed anywhere that fake-display is used (in tests). In addition, this change routes fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed (without regard for whether needed by fake-display). This way flutter engine can migrate to fuchsia.sysmem2.Allocator without needing more protocol routing diffs. flutter/flutter#146858
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
Apr 17, 2024
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed anywhere that fake-display is used (in tests). In addition, this change routes fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed (without regard for whether needed by fake-display). This way flutter engine can migrate to fuchsia.sysmem2.Allocator without needing more protocol routing diffs. flutter/flutter#146858
darshankawar
added
in triage
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
Apr 17, 2024
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed anywhere that fake-display is used (in tests). In addition, this change routes fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed (without regard for whether needed by fake-display). This way flutter engine can migrate to fuchsia.sysmem2.Allocator without needing more protocol routing diffs. flutter/flutter#146858
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
Apr 17, 2024
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed anywhere that fake-display is used (in tests). In addition, this change routes fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed (without regard for whether needed by fake-display). This way flutter engine can migrate to fuchsia.sysmem2.Allocator without needing more protocol routing diffs. flutter/flutter#146858
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
Apr 18, 2024
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed anywhere that fake-display is used (in tests). In addition, this change routes fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed (without regard for whether needed by fake-display). This way flutter engine can migrate to fuchsia.sysmem2.Allocator without needing more protocol routing diffs. flutter/flutter#146858
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
Apr 19, 2024
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed in a few places. flutter/flutter#146858
jonahwilliams
added
P2
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
Apr 23, 2024
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed in a few places. flutter/flutter#146858
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
Apr 24, 2024
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed in a few places. flutter/flutter#146858
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
Apr 24, 2024
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed in a few places. flutter/flutter#146858
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
May 2, 2024
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed. flutter/flutter#146858
|
Missed a couple needed diffs in shell/platform/fuchsia/flutter/tests/integration/embedder/flutter-embedder-test.cc |
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
May 2, 2024
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed. flutter/flutter#146858
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
May 3, 2024
Fuchsia's fake-display will be migrating to sysmem2, which requires fuchsia.sysmem2.Allocator to be routed. flutter/flutter#146858
|
A few more; will post another PR. |
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
May 10, 2024
Route fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed. fixes flutter/flutter#146858
dustingreen
added a commit
to dustingreen/dart_sdk
that referenced
this issue
May 10, 2024
Route fuchsia.sysmem2.Allocator where fuchsia.sysmem.Allocator is routed. fixes flutter/flutter#146858
dustingreen
added a commit
to dustingreen/flutter_engine
that referenced
this issue
May 10, 2024
Route fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed. fixes flutter/flutter#146858
dustingreen
added a commit
to flutter/engine
that referenced
this issue
May 14, 2024
Route fuchsia.sysmem2.Allocator everywhere that fuchsia.sysmem.Allocator is routed. fixes flutter/flutter#146858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
Fuchsia's fake-display will migrate to sysmem2 soon, at which point usages of fake-display (such as in flutter tests) will need to route fuchsia.sysmem2.Allocator.
Expected results
If fuchsia.sysmem2.Allocator is routed, the protocol routing error will be avoided and tests will pass (even with fake-display using fuchsia.sysmem2.Allocator).
Actual results
Fuchsia would log a protocol routing error indicating that fuchsia.sysmem2.Allocator wasn't made available, and some tests would fail. The error would look like this:
Code sample
See the PR for tests that will fail if we don't route fuchsia.sysmem2.Allocator in those tests.
Screenshots or Video
NA
Logs
NA
Flutter Doctor output
NA
The text was updated successfully, but these errors were encountered: