Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Update codeql-action in flutter/plugins scorecards-analysis.yml #116149

Closed
ditman opened this issue Nov 28, 2022 · 5 comments
Closed

[ci] Update codeql-action in flutter/plugins scorecards-analysis.yml #116149

ditman opened this issue Nov 28, 2022 · 5 comments
Labels
P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team-infra Owned by Infrastructure team

Comments

@ditman
Copy link
Member

ditman commented Nov 28, 2022

I just noticed that the flutter/plugins Scorecards analysis action is throwing a deprecation warning from the codeql-action/upload-sarif action:

Run github/codeql-action/upload-sarif@807578363a7869ca324a79039e6db9c843e0e100
Uploading results

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using
Environment Files. For more information see:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

This has already been fixed upstream, so I think that all we need to do is to whitelist and use a newer version of the codeql-action, here.

See the changelog of the action to pick a new hash.

(Note: this is not affecting flutter/packages because it's using a different version of the action? github/codeql-action/upload-sarif@678fc3afe258fb2e0cdc165ccf77b85719de7b3c)

@ditman ditman added the team-infra Owned by Infrastructure team label Nov 28, 2022
@ditman ditman changed the title [ci] Update codeql-action in scorecards-analysis.yml [ci] Update codeql-action in flutter/plugins scorecards-analysis.yml Nov 28, 2022
@ditman
Copy link
Member Author

ditman commented Nov 28, 2022

It seems that flutter/flutter, flutter/engine, flutter/packages and flutter/plugins are using slightly different versions of the action, those should probably be unified :/

@ditman ditman added the plugin label Nov 29, 2022
@godofredoc
Copy link
Contributor

We should probably add the autosubmit label to dependabot github action updates.

flutter/plugins#6712 was opened but not landed.

@ditman
Copy link
Member Author

ditman commented Nov 30, 2022

I had no idea that dependabot was reporting also on github actions themselves! Thanks for the pointer @godofredoc!

@stuartmorgan stuartmorgan added the P2 Important issues not at the top of the work list label Dec 1, 2022
@ditman
Copy link
Member Author

ditman commented Dec 6, 2022

This is fixed now. Compare:

Thanks @bparrishMines!

@ditman ditman closed this as completed Dec 6, 2022
@github-actions
Copy link

github-actions bot commented Mar 5, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team-infra Owned by Infrastructure team
Projects
None yet
Development

No branches or pull requests

3 participants