Allows BeEquivalentTo to handle a non-generic collection as the SUT #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyrup
approved these changes
Nov 19, 2018
| @@ -1598,30 +1616,6 @@ public void When_subject_is_null_and_expectation_is_enumerable_it_should_throw() | |||
| "Expected subject not to be <null>*"); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void When_the_expectation_is_not_a_multi_dimensional_array_it_should_throw() | |||
There was a problem hiding this comment.
❓ Why is this test no longer valid?
There was a problem hiding this comment.
Because since v5, the expectation drives the type of comparison. Since it's a string, it'll never trigger the MultiDimensionalArrayEquivalencyStep
There was a problem hiding this comment.
Makes sense.
Couldn't see how that test should be affected by the other changes in this PR.
There was a problem hiding this comment.
Don't even understand how this entire bug only surfaced now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
GenericEnumerableEquivalencyStepdid not properly support the subject to be a non-generic collection.Fixes #973