Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ExecutionTime acception async action #938

Merged
merged 1 commit into from Oct 7, 2018
Merged

Add ExecutionTime acception async action #938

merged 1 commit into from Oct 7, 2018

Conversation

krajek
Copy link
Contributor

@krajek krajek commented Oct 4, 2018

Closes #858.
A simple generalization of ExecutionMethod allowed enough flexibility to support both Action and Func<Task.

@krajek
Copy link
Contributor Author

krajek commented Oct 5, 2018

I have just adjusted the implementation. Instead of generalizing the code I just added separate ExecutionTime constructor accepting Func<Task>. Some code needed to be copied but I think @jnyrup was right in his review and synchronous and asynchronous cases should be handled separately.

Ready for merge.

@krajek
Copy link
Contributor Author

krajek commented Oct 5, 2018

BTW, follow up PR will deliver ExecutionTimeOf in async mode.

@dennisdoomen dennisdoomen merged commit 7be38a2 into fluentassertions:master Oct 7, 2018
@krajek krajek deleted the async_execution_time branch October 7, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krajek @dennisdoomen @jnyrup