Improve enum comparison assert messages #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyrup
reviewed
Sep 24, 2018
krajek
changed the title
|
@jnyrup Thanks for the review. All suggestions are implemented and is my opinion PR is ready to go |
jnyrup
approved these changes
Sep 25, 2018
dennisdoomen
approved these changes
Sep 26, 2018
There was a problem hiding this comment.
Only minor comments. See the legend for the meaning of the emojis.
| @@ -3599,6 +3595,26 @@ public void When_asserting_members_from_different_enum_types_are_equivalent_by_s | |||
| act.Should().NotThrow(); | |||
| } | |||
|
|
|||
| [Fact] | |||
| public void When_asserting_members_from_different_enum_types_are_equivalent_by_value_but_comparing_by_name_it_should_throw() | |||
There was a problem hiding this comment.
🤔 What are asserting members?
There was a problem hiding this comment.
Would you accept the change to "[...]asserting_that_members_from[...]"? BTW there are many places like this is this particular file and tens in other files :-).
jnyrup
reviewed
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies changes discussed in #897.
Example of the new message:
"Expected enum to be EnumFour.Three(3) by value, but found EnumOne.Two(3)Reviews are welcome.