Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing an object graph against IEnumerable works now as expected #911

Merged
merged 1 commit into from Nov 6, 2018

Conversation

dennisdoomen
Copy link
Member

Added two overloads for Should().BeEquivalentTo that take an IEnumerable and treats those internally as IEnumerable<object>.

Fixes #881

@dennisdoomen dennisdoomen changed the title Comparing an object graph against IEnumerable works now as expected [WIP] Comparing an object graph against IEnumerable works now as expected Sep 11, 2018
@dennisdoomen
Copy link
Member Author

I'll probably extract this into two PRs. One to fix the above mentioned bug and one to fix #918.

@dennisdoomen dennisdoomen changed the title [WIP] Comparing an object graph against IEnumerable works now as expected Comparing an object graph against IEnumerable works now as expected Oct 20, 2018
@dennisdoomen dennisdoomen added this to the 5.5.0 milestone Oct 20, 2018
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling that changing this, would require more new tests, as I expected this to break some special crafted tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants