Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion rules end up in the failure message multiple times #738

Closed
dennisdoomen opened this issue Jan 22, 2018 · 6 comments
Closed

Conversion rules end up in the failure message multiple times #738

dennisdoomen opened this issue Jan 22, 2018 · 6 comments
Labels
Milestone

Comments

@dennisdoomen
Copy link
Member

dennisdoomen commented Jan 22, 2018

With configuration:
- Use declared types and members
- Compare enums by value
- Match member by name (or throw)
- Try conversion of all members. Try conversion of member x.SelectedMemberPath.Contains("Birthdate"). Try conversion of all members. 
- Be strict about the order of items in byte arrays
" does not.
@dennisdoomen dennisdoomen added this to the 5.0.0 RTM milestone Jan 22, 2018
@dennisdoomen
Copy link
Member Author

Can't reproduce

@dennisdoomen
Copy link
Member Author

The TryConversionStep is added every time a new instance of the SelfReferenceEquivalencyAssertionOptions is created. First when it copies over the UserEquivalencySteps from the defaults (which always adds the TryConversionStep as part of it), and possibly later

@dennisdoomen dennisdoomen modified the milestones: 5.0.0 RTM, 5.1.0 Jan 31, 2018
@krajek
Copy link
Contributor

krajek commented Oct 6, 2018

I will tackle the problem. Any comments before I start? Is there any test that reproduces the behaviour? Is it only about duplication in the description or the behaviour itself is also affected?

@dennisdoomen
Copy link
Member Author

It's purely a cosmetic issue.

@jnyrup
Copy link
Member

jnyrup commented Oct 11, 2018

@krajek I guess this can be closed with #941 ?

@krajek
Copy link
Contributor

krajek commented Oct 11, 2018

Absolutely yes, thanks.

When I started #941 I was not sure it will solve the issue. As the PR developed over time fixes reached the root cause of the problem.

@jnyrup jnyrup closed this as completed Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants