Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow anonymous object for selecting fields/properties at Exclude and Include #2488

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Allow anonymous object for selecting fields/properties at Exclude and Include #2488

wants to merge 3 commits into from

Conversation

IT-VBFK
Copy link
Contributor

@IT-VBFK IT-VBFK commented Nov 27, 2023 •
edited

This refers to Excluding() / .For().Exclude() and Including().

To be discussed:

  • With(out)StrictOrderingFor()

This closes #2479

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@IT-VBFK IT-VBFK changed the title SAVEPOINT Excluding properties with anonymous object Nov 27, 2023
@coveralls
Copy link

coveralls commented Nov 27, 2023 •
edited

Pull Request Test Coverage Report for Build 7036088817

  • 24 of 24 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 97.485%
Totals Coverage Status
Change from base Build 7033738205: 0.01%
Covered Lines: 11756
Relevant Lines: 11940
💛 - Coveralls

@IT-VBFK IT-VBFK force-pushed the feat/excluding-with-anonymous-object branch 2 times, most recently from 552be02 to c1e2441 Compare November 28, 2023 16:28
@IT-VBFK IT-VBFK marked this pull request as ready for review November 28, 2023 16:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@IT-VBFK IT-VBFK changed the title Excluding properties with anonymous object Excluding fields and properties with anonymous object Nov 28, 2023
@IT-VBFK IT-VBFK force-pushed the feat/excluding-with-anonymous-object branch 3 times, most recently from e869e49 to 1a87f18 Compare November 28, 2023 20:42
@IT-VBFK IT-VBFK changed the title Excluding fields and properties with anonymous object Allow anonymous object for selecting fields/properties at Exclude and Include Nov 28, 2023
@IT-VBFK IT-VBFK force-pushed the feat/excluding-with-anonymous-object branch from 1a87f18 to 1ac4b66 Compare November 28, 2023 21:19
@IT-VBFK
Copy link
Contributor Author

IT-VBFK commented Nov 29, 2023

Hmm.. discovered a bad bug...

Will fix it in the evening 🫣

@IT-VBFK IT-VBFK force-pushed the feat/excluding-with-anonymous-object branch from 1ac4b66 to 85cba3f Compare November 29, 2023 17:12
@IT-VBFK IT-VBFK marked this pull request as draft November 30, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Support for selecting multiple properties in single expression.
2 participants
@IT-VBFK @coveralls