Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API suggestion] - Change return type for all HaveElement at XDocument and XElement #1904

Closed
ITaluone opened this issue Apr 19, 2022 · 1 comment

Comments

@ITaluone
Copy link
Contributor

ITaluone commented Apr 19, 2022

Before you file a bug, have you:

  • Tried upgrading to newest version of Fluent Assertions, to see if your issue has already been resolved and released?
  • Checked existing open and closed issues, to see if the issue has already been reported?
  • Tried reproducing your problem in a new isolated project?
  • Read the documentation?
  • Considered if this is a general question and not a bug?. For general questions please use StackOverflow.

Description

While implementing #1880 we discussed the return type for the new overloads for HaveElement(string | XName, OccurrenceConstraint). I realized that the "old" HaveElement overloads have a different return type (AndWhichConstraint<XDocumentAssertions, XElement>).

Now I would like to unify this and change the return type to AndWhichConstraint<XDocumentAssertions, IEnumerable<XElement>> as we discussed.

@ITaluone
Copy link
Contributor Author

ITaluone commented Apr 19, 2022

Hmm... after lookin deep into the meaning of AndWhichConstraint and the HaveElement implementation this is a completely unnecessary and more or less wrong "feature".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant