Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intercept Reflection exceptions from AppSettingsConfigurationStore #1210

Merged

Conversation

jnyrup
Copy link
Member

@jnyrup jnyrup commented Dec 29, 2019

Some platforms throw reflection exceptions when trying to use ConfigurationManager.
This does not fix the underlying problem of not being unable to use ConfigurationManager, but returns null instead of an exception.

Relates to #1207 and #1151

Some platforms throws reflection exceptions when trying to use `ConfigurationManager`.
This does not fix the underlying problem of not being unable to use `ConfigurationManager`, but returns `null` instead of an exception.

Relates to fluentassertions#1207 and fluentassertions#1151
@jnyrup jnyrup force-pushed the configurationStoreInterceptor branch from 8c97ed4 to eaa952f Compare December 29, 2019 16:03
@jnyrup jnyrup merged commit 4607f79 into fluentassertions:master Dec 29, 2019
@jnyrup jnyrup deleted the configurationStoreInterceptor branch December 29, 2019 16:15
@SteveBush
Copy link

Current fix returns null for GetSettings but NullConfigurationStore returns an empty string. Seems like a more consistent fix would be to emulate NullConfigurarion store behavior.

@jnyrup
Copy link
Member Author

jnyrup commented Jan 2, 2020

@SteveBush I see the inconsistency.
The code here was intentional, as AppSettingsConfigurationStore can return null.
Are having problems with the merged fix?

@SteveBush
Copy link

SteveBush commented Jan 4, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants