Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JsonResult assertions #10

Closed
kevinkuszyk opened this issue Feb 8, 2013 · 7 comments
Closed

Add JsonResult assertions #10

kevinkuszyk opened this issue Feb 8, 2013 · 7 comments

Comments

@kevinkuszyk
Copy link
Member

No description provided.

@sharpjs
Copy link
Contributor

sharpjs commented May 28, 2014

I have a class I am using for this purpose. I will put together a PR to add it into Fluent Assertions.

@kevinkuszyk
Copy link
Member Author

Great. Looking forward to seeing it.

@kevinkuszyk
Copy link
Member Author

@sharpjs any chance you can commit this to a branch on your fork? I have some time coming up so I may be able to finish this off.

@jamiehumphries
Copy link
Contributor

I was going to maybe take a look at this (because I wanted it on my project 😄) and/or some of the other similar ones like #9, #20, #21. Are there any guidlelines on style, documentation or general contribution that I should have a look at? Or should I just try to keep in line with what is already here?

@kevinkuszyk
Copy link
Member Author

@jamiehumphries great. Just try to follow the existing style and @dennisdoomen's code guide lines. Also, make sure you have tests in the AAA format for each feature.

Feel free to open pull requests early if you want any feedback or code review. I'm finishing work for 2 weeks today, so please bear with me if I'm a little slow in replying over the holidays.

@jamiehumphries
Copy link
Contributor

Great, thanks. I'll hopefully have a look at a few of these over the Christmas break.

@kevinkuszyk
Copy link
Member Author

Closed via #37. Thanks @rikrak!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants