Upgrade to FluentAssertions 5.5.0 yields: System.MissingMethodException

[dstj]

After upgrading FluentAssertions from 5.4.2 to 5.5.0, the following code:

var actualString = @"<JSON HERE>";
var expectedString = @"<JSON HERE>";
var actual = JsonParsingHelper.Parse(actualString);
var expected = JsonParsingHelper.Parse(expectedString);
actual.Should().BeEquivalentTo(expected);

produces the following error:

System.MissingMethodException : Method not found: 'FluentAssertions.Execution.AssertionScope FluentAssertions.Execution.AssertionScope.ForCondition(Boolean)'.
   at FluentAssertions.Json.JTokenAssertions.HaveElement(String expected, String because, Object[] becauseArgs)

[ghost]

any progress on this? I'm getting the same error after upgrading

[dennisdoomen]

Sorry. Forgot about the other repo. Will take a look soon.

[dennisdoomen]

Hmm, looks like I've introduced a breaking change in the main library without me realizing it.

cc @jnyrup

[jnyrup]

@dennisdoomen Probably due to fluentassertions/fluentassertions#925
AssertionScope.ForCondition changed return type from AssertionScope to IAssertionScope, so the function signature is changed.

[dennisdoomen]

Yep. Trying to figure out how we can fix this.

[dennisdoomen]

Looks like the only way to fix this is to have FluentAssertions.Json take a direct dependency on FluentAssertions 5.5.0+. Technically, that's a breaking change..

[jnyrup]

I guess the breaking change also affects all other nuget packages depending on 5.0.0+?

[dennisdoomen]

If they directly use the AssertionScope, yes.

[dennisdoomen]

And you did mention the potential for breaking changes while you reviewed fluentassertions/fluentassertions#925 😢

[jnyrup]

We might be able to fix it by using explicit interface implementation of IAssertionScope in AssertionScope.

I tried it, and here are my results:

• all normal tests of FA completed (note that Ensures expectations involving multiple assertions can be cleared fluentassertions#925 doesn't include any tests)
• the problem from BeEquivalentTo with WithStrictOrdering produces messy failure message fluentassertions#918 remains fixed
• I could dump that new dll into a test project using FluentAssertions.Json 5.0.0 and it worked.

One exception is Continuation also changed Then from returning an AssertionScope to an IAssertionScope

[dennisdoomen]

That was exactly what I was thinking as well.

[dennisdoomen]

Should be fixed by https://github.com/fluentassertions/fluentassertions/releases/tag/5.5.3