Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime configuration check #4268

Open
pepov opened this issue Aug 14, 2023 · 4 comments
Open

Runtime configuration check #4268

pepov opened this issue Aug 14, 2023 · 4 comments

Comments

@pepov
Copy link

pepov commented Aug 14, 2023

Is your feature request related to a problem? Please describe.

In order to verify that a configuration is syntactically valid I can already run fluentd with the --dry-run flag. I would like to check if fluentd can actually start with the configuration.
This would help in cases when for example one specific output is not compatible with the available plugins, which we cannot detect using --dry-run.

Describe the solution you'd like

I would like to be able to start fluentd with a configuration and tell it using some command line flags to start but quit with a zero exit code, if everything has been initialized properly.

Describe alternatives you've considered

Right now I can achieve something similar by running fluentd using the timeout command, however that is suboptimal:
kube-logging/logging-operator#1407

Additional context

This feature would be leveraged by the logging operator in it's automatic config check feature:
kube-logging/logging-operator#1432

@kenhys
Copy link
Contributor

kenhys commented Aug 23, 2023

What combination of output plugins, did you assume to detect (for example)?

@pepov
Copy link
Author

pepov commented Aug 23, 2023

Any combination that the user configures. The way it works is that we create a separate pod without sending traffic to it with the configuration we are about to actually deploy. If the check fails we back up, if not we proceed.

@github-actions
Copy link

This issue has been automatically marked as stale because it has been open 30 days with no activity. Remove stale label or comment or this issue will be closed in 7 days

@pepov
Copy link
Author

pepov commented Oct 5, 2023

FYI This has been implemented for syslog-ng per our (logging-operator) request like this:
syslog-ng/syslog-ng#4646

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants