Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_in_tail: Try to fix unstable test_shutdown_timeout #3783

Merged
merged 1 commit into from Jun 14, 2022

Conversation

ashie
Copy link
Member

@ashie ashie commented Jun 13, 2022

Which issue(s) this PR fixes:
None

What this PR does / why we need it:
test_shutdown_timeout in test_in_tail is a bit unstable on Drone.io and macOS.
Probably the cause is that recording start time is too early.

Docs Changes:
None

Release Note:
None

@ashie ashie changed the title test_in_tail: Try to fix an unstable test_shutdown_timeout test_in_tail: Try to fix unstable test_shutdown_timeout Jun 13, 2022
@ashie ashie force-pushed the try-to-fix-unstable-in-tail-test branch from 0ace43a to ab3d72c Compare June 13, 2022 13:16
@ashie ashie marked this pull request as draft June 13, 2022 14:56
@ashie
Copy link
Member Author

ashie commented Jun 13, 2022

It seems that sometimes timeout occurs.

Probably the cause is that recording start time is too early.

Signed-off-by: Takuro Ashie <ashie@clear-code.com>
@ashie ashie force-pushed the try-to-fix-unstable-in-tail-test branch from ab3d72c to e2760c8 Compare June 13, 2022 23:53
@ashie ashie marked this pull request as ready for review June 14, 2022 00:26
@ashie
Copy link
Member Author

ashie commented Jun 14, 2022

It seems that sometimes timeout occurs.

Fixed.

@ashie ashie merged commit aafc3b8 into master Jun 14, 2022
@ashie ashie deleted the try-to-fix-unstable-in-tail-test branch June 14, 2022 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant